Update installation documentation with Minishift #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
knative-prow-robot
added
the
needs-ok-to-test
|
/ok-to-test |
knative-prow-robot
added
lgtm
|
/lgtm need to move to 0.5.0 ( a rebase will probably do this and fix the conflict) |
xeviknal
force-pushed
the
minishift-update
branch
from
8808dc8 to
0aa262d
Compare
|
Changes rebased from master :) |
|
There's a conflict to resolve, then we should be able to get this merged in, @xeviknal |
xeviknal
force-pushed
the
minishift-update
branch
from
0aa262d to
f03db49
Compare
|
Conflicts resolved :) |
|
/approve |
samodell
added
cherrypick-0.5
and removed
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samodell, xeviknal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
samodell
pushed a commit
to samodell/docs
that referenced
this pull request
Apr 23, 2019
* Remove usage of kubectl. Using oc instead * Update webhook admissions
Merged
knative-prow-robot
pushed a commit
that referenced
this pull request
Apr 24, 2019
* Knative with Gardener - Fix Installing Istio Typo (#1027) * Update installation documentation with Minishift (#1114) * Remove usage of kubectl. Using oc instead * Update webhook admissions * Mention IKS's one-click install process (#1131) Signed-off-by: Doug Davis <[email protected]> * helloworld-go: install CA certs (#1143) * helloworld-go: install CA certs All users who are querying any HTTPS endpoints will need this and won't understand why it's failing. * address fixes Signed-off-by: Ahmet Alp Balkan <[email protected]> * Use istio-ingressgateway servce as this is the new one used in Knative 0.3 and above (#1171) * knative.slack.com -> slack.knative.dev (#1176) * Update Knative-custom-install.md (#1178) change the name `release.yaml` to `build.yaml` * fix README (#1180) Replace pubspec field `private` with `publish_to`. [ref](https://www.dartlang.org/tools/pub/pubspec#publish_to) See @52f464f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
kubectlcommands byoc