chore: run workflow once the PR is created by job #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarkaaa
changed the title
|
Storybook staging is available at https://kiwicom-orbit-sarka-fix-cron-update-icons.surge.sh |
|
Size Change: +2 B (0%) Total Size: 445 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
129665b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a99b212f.orbit.pages.dev |
| Branch Preview URL: | https://sarka-fix-cron-update-icons.orbit.pages.dev |
sarkaaa
force-pushed
the
sarka/fix-cron-update-icons
branch
from
b9f2172 to
43aab1d
Compare
DSil
reviewed
Jul 4, 2024
|
Hi, I was searching for how to achieve our goal and it seems it's not doable to run GH workflow from another GH workflow automatically, I've found this solution by using GitHub apps, but I am not sure if it's the way how we want to solve this issue. Also, I have found some solutions using Personal Access Token, but from my POV it's not ideal either. 🤷♀️ btw, an interesting discussion about this problem is here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens I'll try to do deeper research and in case I still won't be successful, can we discuss it next week, please? |
That might be an option. We are using PAT for other things, like updating visual tests… So we can use the @kiwicom-orbit-bot PAT and make it the creator of the PRs, if that's what's necessary to have the pipeline run automatically. |
|
This PR is not linked to any Jira task. Please bear in mind that the Kanban board acts as the source of truth. If it's not visible there it might go unnoticed. |
Thank you for the reply. I'll take a look at it deeper on Monday. |
sarkaaa
force-pushed
the
sarka/fix-cron-update-icons
branch
14 times, most recently
from
e9ce58f to
d606e86
Compare
DSil
reviewed
Jul 8, 2024
| @@ -46,6 +46,7 @@ jobs: | |||
| uses: actions/github-script@v6 | |||
| if: env.new_files == 'true' | |||
| with: | |||
| github-token: ${{ secrets.PAT}} | |||
There was a problem hiding this comment.
Suggested change
| github-token: ${{ secrets.PAT}} | |
| github-token: ${{ secrets.PAT }} |
sarkaaa
force-pushed
the
sarka/fix-cron-update-icons
branch
from
d606e86 to
6614c88
Compare
sarkaaa
force-pushed
the
sarka/fix-cron-update-icons
branch
from
6614c88 to
129665b
Compare
sarkaaa
changed the title
DSil
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes news settings of GitHub actions workflow - once the once the PR is (automatically) created then its respective GH actions are triggered.
Jira ticket: https://kiwicom.atlassian.net/browse/FEPLT-2003