Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and run
gofumpt
onexcludes.go
, and update dependencies. (errcheck is failing for me, with errorpackage "reflect" without types was imported from "github.com/gnolang/gno/gnovm/pkg/gnolang"
-- I think this is due to type parameters, and updating x/tools fixes the issue).The reason why I think we should not exclude fmt.Errorf is that, by making sure it is used, we catch wrong code like:
This is obviously meant to return the error, but it's not.
If the current behaviour is to be considered correct, then
errors.New
should also be excepted.