fix: don't exclude fmt.Errorf (#235)

kisielk · Nov 9, 2023 · a75c8d0 · a75c8d0
1 parent 1a21a9c
commit a75c8d0
Showing 1 changed file with 36 additions and 40 deletions.
diff --git a/errcheck/excludes.go b/errcheck/excludes.go
@@ -7,56 +7,52 @@ import (
 	"strings"
 )
 
-var (
-	// DefaultExcludedSymbols is a list of symbol names that are usually excluded from checks by default.
-	//
-	// Note, that they still need to be explicitly copied to Checker.Exclusions.Symbols
-	DefaultExcludedSymbols = []string{
-		// bytes
-		"(*bytes.Buffer).Write",
-		"(*bytes.Buffer).WriteByte",
-		"(*bytes.Buffer).WriteRune",
-		"(*bytes.Buffer).WriteString",
+// DefaultExcludedSymbols is a list of symbol names that are usually excluded from checks by default.
+//
+// Note, that they still need to be explicitly copied to Checker.Exclusions.Symbols
+var DefaultExcludedSymbols = []string{
+	// bytes
+	"(*bytes.Buffer).Write",
+	"(*bytes.Buffer).WriteByte",
+	"(*bytes.Buffer).WriteRune",
+	"(*bytes.Buffer).WriteString",
 
-		// fmt
-		"fmt.Errorf",
-		"fmt.Print",
-		"fmt.Printf",
-		"fmt.Println",
-		"fmt.Fprint(*bytes.Buffer)",
-		"fmt.Fprintf(*bytes.Buffer)",
-		"fmt.Fprintln(*bytes.Buffer)",
-		"fmt.Fprint(*strings.Builder)",
-		"fmt.Fprintf(*strings.Builder)",
-		"fmt.Fprintln(*strings.Builder)",
-		"fmt.Fprint(os.Stderr)",
-		"fmt.Fprintf(os.Stderr)",
-		"fmt.Fprintln(os.Stderr)",
+	// fmt
+	"fmt.Print",
+	"fmt.Printf",
+	"fmt.Println",
+	"fmt.Fprint(*bytes.Buffer)",
+	"fmt.Fprintf(*bytes.Buffer)",
+	"fmt.Fprintln(*bytes.Buffer)",
+	"fmt.Fprint(*strings.Builder)",
+	"fmt.Fprintf(*strings.Builder)",
+	"fmt.Fprintln(*strings.Builder)",
+	"fmt.Fprint(os.Stderr)",
+	"fmt.Fprintf(os.Stderr)",
+	"fmt.Fprintln(os.Stderr)",
 
-		// io
-		"(*io.PipeReader).CloseWithError",
-		"(*io.PipeWriter).CloseWithError",
+	// io
+	"(*io.PipeReader).CloseWithError",
+	"(*io.PipeWriter).CloseWithError",
 
-		// math/rand
-		"math/rand.Read",
-		"(*math/rand.Rand).Read",
+	// math/rand
+	"math/rand.Read",
+	"(*math/rand.Rand).Read",
 
-		// strings
-		"(*strings.Builder).Write",
-		"(*strings.Builder).WriteByte",
-		"(*strings.Builder).WriteRune",
-		"(*strings.Builder).WriteString",
+	// strings
+	"(*strings.Builder).Write",
+	"(*strings.Builder).WriteByte",
+	"(*strings.Builder).WriteRune",
+	"(*strings.Builder).WriteString",
 
-		// hash
-		"(hash.Hash).Write",
-	}
-)
+	// hash
+	"(hash.Hash).Write",
+}
 
 // ReadExcludes reads an excludes file, a newline delimited file that lists
 // patterns for which to allow unchecked errors.
 //
 // Lines that start with two forward slashes are considered comments and are ignored.
-//
 func ReadExcludes(path string) ([]string, error) {
 	var excludes []string