-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite internals of EffectDrawBase
#310
Conversation
No problem on my side, behave like expected with great performance improvements |
I annoyingly discovered a bug with Whilst trying to fix this bug I also discovered that the core functionality was completely disabled and broken in #259 for some reason. I think the bug this was supposed to fix needs a solution, hopefully I can come up with one that retains the functionality of the transitioning content control. |
I'm not 100% certain I've fixed the issue that #259 was supposed to fix, but it should do the job, now the back buffer is cleared out and you can assign |
Could you confirm that #259 isn't regressed with these changes @AuroraZiling? If the crash is back, please send me a repro and I'll try and implement a better solution. |
confirmed, the issue isn't regressed |
Thanks for the suggestions @maxkatz6, PR is ready to go. I won't merge it myself just so one final sanity check gets done before it gets merged. |
I tested it, LGTM |
Changes
EffectDrawBase
now usesCompositionCustomVisualHandler
.SukiTransitioningContentControl
.null
to the content is now valid which should make detaching content from the visual tree work as intended.Outstanding Issues
Loading
control - even when invalidating only the rect for it - still has very high GPU utilisation and I'm not quite sure why.ShaderToyRenderer
in the demo also suffers from this same issue - though it seems to use less GPU for reasons beyond my understanding.SukiWindow
at the moment.I wanted to ideally have at least one or two other people test this to make sure the GPU/CPU issues are in fact under control and everything renders correctly, before this gets merged as it's a pretty major internal change.