[Fix] TransitioningContentControl
crushes when a view attaches visual tree many times
#259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #258
What Happened:
When adding some items after emptying the
SukiSideMenu
, it can causeTransitioningContentControl
to crash if those added items ever appear.Possible Causes:
The
Views
that were found to be causing the problem had theirVisualParent
in theTransitioningContentControl
'sPushContent()
function not empty, but eitherFirstBuffer
orSecondBuffer
. because theVisualParent
was reassigned to anotherBuffer
when it was not empty, this would cause a crash.I don't know if there will be any side effects from this pr, but this solves the problem