MBL-1745: Replace additional strings with translated strings #2140
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2140 +/- ##
=========================================
Coverage 67.77% 67.78%
- Complexity 2233 2234 +1
=========================================
Files 368 368
Lines 22889 22889
Branches 3294 3294
=========================================
+ Hits 15514 15515 +1
Misses 5603 5603
+ Partials 1772 1771 -1 ☔ View full report in Codecov by Sentry. |
leighdouglas
force-pushed
the
leigh/mbl-1745-strings
branch
from
6f09743
to
56cca1f
Compare
| @@ -415,7 +415,7 @@ fun ConfirmAddressButtonsView(isConfirmButtonEnabled: Boolean, onEditAddressClic | |||
| modifier = Modifier | |||
| .weight(0.5f), | |||
| onClickAction = { onEditAddressClicked.invoke() }, | |||
| text = stringResource(id = R.string.edit_fpo), | |||
| text = stringResource(id = R.string.discovery_favorite_categories_buttons_edit), | |||
There was a problem hiding this comment.
The french string for "Edit" was translated wrong. While the translation folx corrected the translation, for some reason it won't update on our end, so i found this already translated string for "Edit" that is correct. we can use this for now until the other translation stuff is sorted.
leighdouglas
changed the title
| @@ -219,6 +221,7 @@ Cliquez pour réessayer.</string> | |||
| <string name="Double_tap_to_toggle_setting" formatted="false">Cliquez deux fois pour activer/désactiver le réglage</string> | |||
| <string name="Download_your_personal_data" formatted="false">Téléchargement de vos données personnelles</string> | |||
| <string name="Earth" formatted="false">Terre</string> | |||
| <string name="Edit" formatted="false">Edit</string> | |||
There was a problem hiding this comment.
This is the string that won't update with the new translation from the server
📲 What
String translations for PPO
🤔 Why
PPO!
📋 QA
If you feel like testing in another language, make sure strings are translated and formatted properly.
Story 📖
MBL-1745: Replace additional strings with translated strings