-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-1556: Add network calls to confirm address and requery the PPO card list #2088
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c28f625
Add infinite scroll to PPO screen
ycheng-kickstarter 996edd8
Attempting to fix tests
29ffcdb
Test paging source
578c14d
linter
fe51786
Merge conflicts
987b385
Linter
75a08af
Fixes
9f250f8
Linter
f7ab392
Testing
e071e7e
Fix
702c8eb
update graphql schema
00edd7a
merge
db8b8aa
fix
22e5828
Hooked up requery and tests
094a4a0
lint
54b1534
Cleanup
7974c67
trying to fix tests
edb6c6e
Fixed flaky tests
c1ee315
Cleanup
901995e
lint
8a20db1
Merge master into branch
b9e863f
cleanup
d5e1dff
linter
8342b8f
Merge branch 'master' into leigh/mbl-1556-ca-requery
leighdouglas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -369,6 +369,9 @@ fragment ppoCard on Backing { | |
amount { | ||
...amount | ||
} | ||
deliveryAddress { | ||
id | ||
} | ||
project { | ||
name | ||
id | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,23 @@ | ||
query PledgedProjectsOverview($first: Int, $after: String, $last: Int, $before: String) { | ||
pledgeProjectsOverview { | ||
categories { | ||
count | ||
slug | ||
title | ||
} | ||
pledges(first : $first, after: $after, last : $last, before: $before) { | ||
pageInfo { | ||
endCursor | ||
hasNextPage | ||
hasPreviousPage | ||
startCursor | ||
} | ||
pledgeProjectsOverview { | ||
pledges(first : $first, after: $after, last : $last, before: $before) { | ||
totalCount | ||
edges { | ||
cursor | ||
cursor | ||
node { | ||
backing { | ||
... ppoCard | ||
} | ||
backing { | ||
...ppoCard | ||
} | ||
tierType | ||
tags | ||
} | ||
} | ||
nodes { | ||
backing { | ||
... ppoCard | ||
} | ||
pageInfo { | ||
hasPreviousPage | ||
hasNextPage | ||
endCursor | ||
startCursor | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arkariang @mtgriego im a bit nervous about this change. this change was required after i downloaded the new graphql schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would affect the feature branch, but if changes are needed there we can add it back in before merging to master, though to be safe lets hold the merge until we can confirm with Isa tomorrow