-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-1556: Add network calls to confirm address and requery the PPO card list #2088
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
============================================
+ Coverage 67.49% 67.65% +0.15%
- Complexity 2126 2127 +1
============================================
Files 363 363
Lines 22105 22100 -5
Branches 3104 3106 +2
============================================
+ Hits 14920 14951 +31
+ Misses 5544 5506 -38
- Partials 1641 1643 +2 ☔ View full report in Codecov by Sentry. |
@@ -78,8 +78,8 @@ mutation CompleteOnSessionCheckout($checkoutId: ID!, $paymentIntentClientSecret: | |||
} | |||
} | |||
|
|||
mutation completeOrder($projectId: ID! $stripePaymentMethodId: String, $paymentSourceId: String, $paymentSourceReusable: Boolean, $paymentMethodTypes: [String!]) { | |||
completeOrder(input:{ projectId: $projectId, stripePaymentMethodId: $stripePaymentMethodId, paymentSourceId: $paymentSourceId, paymentSourceReusable: $paymentSourceReusable, paymentMethodTypes: $paymentMethodTypes }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arkariang @mtgriego im a bit nervous about this change. this change was required after i downloaded the new graphql schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would affect the feature branch, but if changes are needed there we can add it back in before merging to master, though to be safe lets hold the merge until we can confirm with Isa tomorrow
📲 What
schema.graphql
and removeschema.json
, including the small changes needed with the switch🤔 Why
ppo!
🛠 How
schema.graph
moving forwardCreateOrUpdateBackingAddress
, if that is successful, it then refreshes the ppo list by sending a new query request toPledgedProjectsOverview
. otherwise we show an error👀 See
Please note -> the "requery" does not dismiss the card because we are using mocked/hardcoded data for example purposes.
Success:
happypath-confirm-address-requery.mp4
Error:
unhappypath-confirm-address-requery-error.mp4
📋 QA
Please note -> the requery occurs but does not dismiss the card because we are using mocked/hardcoded data for example and testing purposes.
Happy path:
backingID
andaddressID
associated with your account. i used graphiql to find mineconfirmAddressCard()
function, replace theaddressID
andbackingID
values with the ones associate with your accountGraphqlTransformers
, add a confirm address card to the list, generated by thePPOCardFactory.confirmAddressCard()
functionCreateOrUpdateBackingAddress
, which returnstrue
, and one toPledgedProjectsOverview
Unhappy path/errors:
addressID
and thebackingID
values in thePOCardFactory.confirmAddressCard()
function are both not real ids, can be a random string of charactersGraphqlTransformers
, add a confirm address card to the list, generated by thePPOCardFactory.confirmAddressCard()
functionCreateOrUpdateBackingAddress
with a response offalse
Story 📖
MBL-1556: Add network calls to confirm address and requery the PPO card list