Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1403 Stripe Link #2038

Merged
merged 10 commits into from
May 16, 2024
Merged

MBL-1403 Stripe Link #2038

merged 10 commits into from
May 16, 2024

Conversation

ycheng-kickstarter
Copy link
Contributor

@ycheng-kickstarter ycheng-kickstarter commented May 14, 2024

📲 What

Implement Stripe Link

🤔 Why

To enable 1-click checkout

🛠 How

Update Stripe sdk version to 20.42.0
Pass in user email to PaymentSheet.Configuration
Hide Stripe Link on user's payment methods settings screen to match iOS and web behavior

👀 See

User adds a new payment method and can check the box at the bottom that saves the info to Link OR click on green Pay with Link button on top:

A return user sees the option to Pay with Link with their associated email:

Users should not see Link enabled in their settings payment methods. Unfortunately there isn't a clientside way to turn it completely off; instead they'll see an extra email field which is not ideal:

📋 QA

Manually override the feature flag value in ContextExt.kt to make it easier to QA for now.
When you get to the verification step in the Stripe Link checkout flow, enter 000000

Try out the new Stripe Link flow for adding new payment methods on

  • Pledge flow
  • Late pledge flow

Stripe Link should NOT be an option on the payment methods settings screen

  • Settings-> Account -> Payment methods

Reminder that test cards can be found here: https://docs.stripe.com/testing

Story 📖

https://kickstarter.atlassian.net/browse/MBL-1403

@@ -112,7 +112,7 @@ fun FormularyScreen(
value = outputs.email().subscribeAsState(initial = "").value,
onValueChange = {},
readOnly = true,
label = { Text(stringResource(id = R.string.email)) },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone explain to me where this R.string.email string went? It's not in strings_i18n.xml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings_i18n.xml is automatically generated after executing milkrun update-strings (to obtain translations, take a look at this guru card). I assume the latest translations got that changed

@ycheng-kickstarter ycheng-kickstarter marked this pull request as ready for review May 15, 2024 17:48
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 67.79%. Comparing base (4ce4997) to head (086348a).

Files Patch % Lines
...om/kickstarter/libs/utils/extensions/ContextExt.kt 0.00% 10 Missing ⚠️
...ckstarter/ui/activities/compose/FormularyScreen.kt 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2038      +/-   ##
============================================
- Coverage     67.82%   67.79%   -0.03%     
- Complexity     2096     2097       +1     
============================================
  Files           353      353              
  Lines         21554    21564      +10     
  Branches       3043     3044       +1     
============================================
+ Hits          14618    14620       +2     
- Misses         5295     5304       +9     
+ Partials       1641     1640       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ycheng-kickstarter ycheng-kickstarter merged commit d407dc2 into master May 16, 2024
3 checks passed
@ycheng-kickstarter ycheng-kickstarter deleted the MBL-1403-stripe-link branch May 16, 2024 14:16
@ycheng-kickstarter ycheng-kickstarter self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants