-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-1403 Stripe Link #2038
MBL-1403 Stripe Link #2038
Conversation
@@ -112,7 +112,7 @@ fun FormularyScreen( | |||
value = outputs.email().subscribeAsState(initial = "").value, | |||
onValueChange = {}, | |||
readOnly = true, | |||
label = { Text(stringResource(id = R.string.email)) }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone explain to me where this R.string.email
string went? It's not in strings_i18n.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings_i18n.xml
is automatically generated after executing milkrun update-strings
(to obtain translations, take a look at this guru card). I assume the latest translations got that changed
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2038 +/- ##
============================================
- Coverage 67.82% 67.79% -0.03%
- Complexity 2096 2097 +1
============================================
Files 353 353
Lines 21554 21564 +10
Branches 3043 3044 +1
============================================
+ Hits 14618 14620 +2
- Misses 5295 5304 +9
+ Partials 1641 1640 -1 ☔ View full report in Codecov by Sentry. |
📲 What
Implement Stripe Link
🤔 Why
To enable 1-click checkout
🛠 How
Update Stripe sdk version to 20.42.0
Pass in user email to PaymentSheet.Configuration
Hide Stripe Link on user's payment methods settings screen to match iOS and web behavior
👀 See
User adds a new payment method and can check the box at the bottom that saves the info to Link OR click on green Pay with Link button on top:
A return user sees the option to Pay with Link with their associated email:
Users should not see Link enabled in their settings payment methods. Unfortunately there isn't a clientside way to turn it completely off; instead they'll see an extra email field which is not ideal:
📋 QA
Manually override the feature flag value in ContextExt.kt to make it easier to QA for now.
When you get to the verification step in the Stripe Link checkout flow, enter 000000
Try out the new Stripe Link flow for adding new payment methods on
Stripe Link should NOT be an option on the payment methods settings screen
Reminder that test cards can be found here: https://docs.stripe.com/testing
Story 📖
https://kickstarter.atlassian.net/browse/MBL-1403