-
Notifications
You must be signed in to change notification settings - Fork 986
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Upgrade Stripe SDK to 20.42.0 * Pass in userEmail and add feature flag * Fix feature gating logic * Revert Link on Payment Methods Settings to match iOS and web behavior. * Fix tests * Lint * Remove hardcoded flag value * Comments
- Loading branch information
1 parent
4ce4997
commit d407dc2
Showing
12 changed files
with
46 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,7 +107,7 @@ class PledgeFragmentViewModelTest : KSRobolectricTestCase() { | |
private val shippingSummaryAmount = TestSubscriber<CharSequence>() | ||
private val shippingSummaryIsGone = TestSubscriber<Boolean>() | ||
private val shippingSummaryLocation = TestSubscriber<String>() | ||
private val presentPaymentSheet = TestSubscriber<String>() | ||
private val presentPaymentSheet = TestSubscriber<Pair<String, String>>() | ||
private val showPledgeError = TestSubscriber<Unit>() | ||
private val showPledgeSuccess = TestSubscriber<Pair<CheckoutData, PledgeData>>() | ||
private val showSelectedCard = TestSubscriber<Pair<Int, CardState>>() | ||
|
@@ -1966,7 +1966,7 @@ class PledgeFragmentViewModelTest : KSRobolectricTestCase() { | |
|
||
// - Configure PaymentSheet | ||
this.vm.inputs.newCardButtonClicked() | ||
this.presentPaymentSheet.assertValue(clientSecretID) | ||
this.presentPaymentSheet.assertValue(Pair(clientSecretID, "[email protected]")) | ||
this.segmentTrack.assertValue(EventName.PAGE_VIEWED.eventName) | ||
this.pledgeButtonIsEnabled.assertValues(true, false) | ||
this.loadingState.assertValues(State.LOADING) | ||
|
@@ -2021,7 +2021,7 @@ class PledgeFragmentViewModelTest : KSRobolectricTestCase() { | |
setUpEnvironment(environment, RewardFactory.noReward(), backedProject, PledgeReason.FIX_PLEDGE) | ||
|
||
this.vm.inputs.newCardButtonClicked() | ||
this.presentPaymentSheet.assertValue("") | ||
this.presentPaymentSheet.assertValue(Pair("", "[email protected]")) | ||
this.segmentTrack.assertNoValues() | ||
this.pledgeButtonIsEnabled.assertValues(false, false) | ||
this.loadingState.assertValues(State.LOADING) | ||
|
@@ -2042,7 +2042,7 @@ class PledgeFragmentViewModelTest : KSRobolectricTestCase() { | |
setUpEnvironment(environment, RewardFactory.noReward(), backedProject, PledgeReason.UPDATE_PAYMENT) | ||
|
||
this.vm.inputs.newCardButtonClicked() | ||
this.presentPaymentSheet.assertValue("") | ||
this.presentPaymentSheet.assertValue(Pair("", "[email protected]")) | ||
this.segmentTrack.assertValue(EventName.PAGE_VIEWED.eventName) | ||
this.pledgeButtonIsEnabled.assertValues(true, false) | ||
this.loadingState.assertValues(State.LOADING) | ||
|