Skip to content

Commit

Permalink
Removes the server side deps for metrics and entities (elastic#120412) (
Browse files Browse the repository at this point in the history
elastic#120658)

## Summary

See: elastic#110903

This removes all the top level API `export *` spots from:
* `metrics_entities` plugin within the server section

This reduces the number of metrics and warning about undocumented functions.

In the file `metrics_entites/server/index.ts` I now put the advice of:

```
// Careful of exporting anything from this file as any file(s) you export here will cause your functions to be exposed as public.
// If you're using functions/types/etc... internally or within integration tests it's best to import directly from their paths
// than expose the functions/types/etc... here. You should _only_ expose functions/types/etc... that need to be shared with other plugins here.
// When you do have to add things here you might want to consider creating a package such to share with other plugins instead as packages
// are easier to break down.
// See: https://docs.elastic.dev/kibana-dev-docs/key-concepts/platform-intro#public-plugin-api
```

Co-authored-by: Frank Hassanabad <[email protected]>
  • Loading branch information
kibanamachine and FrankHassanabad authored Dec 7, 2021
1 parent 66594bb commit cb85623
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
13 changes: 6 additions & 7 deletions x-pack/plugins/metrics_entities/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
* 2.0.
*/

// TODO: https://github.com/elastic/kibana/issues/110904
/* eslint-disable @kbn/eslint/no_export_all */

export const PLUGIN_ID = 'metricsEntities';
export const PLUGIN_NAME = 'metrics_entities';

export * from './constants';
// Careful of exporting anything from this file as any file(s) you export here will cause your functions to be exposed as public.
// If you're using functions/types/etc... internally or within integration tests it's best to import directly from their paths
// than expose the functions/types/etc... here. You should _only_ expose functions/types/etc... that need to be shared with other plugins here.
// When you do have to add things here you might want to consider creating a package such to share with other plugins instead as packages
// are easier to break down.
// See: https://docs.elastic.dev/kibana-dev-docs/key-concepts/platform-intro#public-plugin-api
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { ELASTIC_NAME } from '../../../common';
import { ELASTIC_NAME } from '../../../common/constants';

export const computeTransformId = ({
prefix,
Expand Down

0 comments on commit cb85623

Please sign in to comment.