AlertWithPersistence return only alerts that were actually indexed (e…

…lastic#120439) (elastic#120669) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
kibanamachine · Dec 7, 2021 · 66594bb · 66594bb
1 parent 7f292d6
commit 66594bb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/x-pack/plugins/rule_registry/server/rule_data_client/rule_data_client.ts b/x-pack/plugins/rule_registry/server/rule_data_client/rule_data_client.ts
@@ -192,7 +192,7 @@ export class RuleDataClient implements IRuleDataClient {
             return clusterClient.bulk(requestWithDefaultParameters).then((response) => {
               if (response.body.errors) {
                 const error = new errors.ResponseError(response);
-                throw error;
+                this.options.logger.error(error);
               }
               return response;
             });

diff --git a/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts b/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
@@ -97,14 +97,16 @@ export const createPersistenceRuleTypeWrapper: CreatePersistenceRuleTypeWrapper
                 }
 
                 return {
-                  createdAlerts: augmentedAlerts.map((alert, idx) => {
-                    const responseItem = response.body.items[idx].create;
-                    return {
-                      _id: responseItem?._id ?? '',
-                      _index: responseItem?._index ?? '',
-                      ...alert._source,
-                    };
-                  }),
+                  createdAlerts: augmentedAlerts
+                    .map((alert, idx) => {
+                      const responseItem = response.body.items[idx].create;
+                      return {
+                        _id: responseItem?._id ?? '',
+                        _index: responseItem?._index ?? '',
+                        ...alert._source,
+                      };
+                    })
+                    .filter((_, idx) => response.body.items[idx].create?.status === 201),
                 };
               } else {
                 logger.debug('Writing is disabled.');