feat: get only user apps in file-movement for performance aspect, add…

… comments (appium#1014)

* get only user app in file management since UIFileSharingEnabled probably only has user app

lib/commands/file-movement.js

@@ -327,13 +327,16 @@ async function pullFromRealDevice (device, remotePath, isFile) {
 /**
  * Get bundleIds which can mount by `--documents` flag
  *
+ *
  * @param {Object} udid - The udid of the target device
- * @returns {Array<string>} A list of bundle ids
+ * @returns {Array<string>} A list of User level apps' bundle ids which has
+ *                          'UIFileSharingEnabled' attribute.
+ *                          Only user apps might have it.
  */
 async function getAvailableBundleIds (udid) {
   const service = await services.startInstallationProxyService(udid);
   try {
-    const applications = await service.listApplications();
+    const applications = await service.listApplications({applicationType: 'User'});
     const bundleIds = [];
     for (const [key, value] of Object.entries(applications)) {
       if (!value.UIFileSharingEnabled) {

lib/ios-deploy.js

@@ -100,6 +100,18 @@ class IOSDeploy {
     await this.install(app);
   }
 
+  /**
+   * Return an application object if test app has 'bundleid'.
+   * The target bundleid can be User and System apps.
+   * @param {string} bundleid The bundleId to ensure it is installed
+   * @return {boolean} Returns True if the bundleid exists in the result of 'listApplications' like:
+   * { "com.apple.Preferences":{
+   *   "UIRequiredDeviceCapabilities":["arm64"],
+   *   "UIRequiresFullScreen":true,
+   *   "CFBundleInfoDictionaryVersion":"6.0",
+   *   "Entitlements":
+   *     {"com.apple.frontboard.delete-application-snapshots":true,..
+   */
   async isAppInstalled (bundleid) {
     const service = await services.startInstallationProxyService(this.udid);
     try {