feat: get only user apps in file-movement for performance aspect, add comments #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @umutuzgur I checked file-management, too. |
|
https://github.com/appium/appium-ios-device/pull/38/files is pretty good. |
…bly only has user app
KazuCocoa
commented
Jul 26, 2019
| */ | ||
| async function getAvailableBundleIds (udid) { | ||
| const service = await services.startInstallationProxyService(udid); | ||
| try { | ||
| const applications = await service.listApplications(); | ||
| const applications = await service.listApplications({applicationType: 'User'}); |
There was a problem hiding this comment.
I haven't find UIFileSharingEnabled in system apps so far.
We can ignore it, for now, to improve find app performance.
KazuCocoa
changed the title
KazuCocoa
changed the title
umutuzgur
reviewed
Jul 26, 2019
| * "CFBundleInfoDictionaryVersion":"6.0", | ||
| * "Entitlements": | ||
| * {"com.apple.frontboard.delete-application-snapshots":true,.. | ||
| */ |
There was a problem hiding this comment.
I can actually speed this part up by using a different API. We can directly ask the phone if a certain bundle id is present. I will try to implement that today
umutuzgur
approved these changes
Jul 26, 2019
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
… comments (appium#1014) * get only user app in file management since UIFileSharingEnabled probably only has user app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes appium/appium#12981