Drop eslint and prettier from CI, update Contributor Covenant Code of Conduct
#8910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Nov 14, 2023
| - uses: ./.github/actions/ci-setup | ||
|
|
||
| - name: TypeScript | ||
| run: pnpm lint:types |
There was a problem hiding this comment.
We don't need to check typescript on Windows
dcousens
force-pushed
the
no-eslint
branch
2 times, most recently
from
e71d984 to
10183a3
Compare
|
The root |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eedaf3e:
|
borisno2
reviewed
Nov 15, 2023
borisno2
approved these changes
Nov 15, 2023
Merged
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linting tooling is not helping the productivity of this project at this time, and as the primary maintainer, I am finding myself spending more time fighting the "errors" than I want to be. As part of this pull request, I am removing any linting tooling as part of our continuous integration pipeline.
This pull request additionally bumps the Contributor Covenant Code of Conduct to version 2.1.
Lastly, this pull request uses
eslint --fixto apply a number of project-wide rules.The rules have been applied atomically in their commits, to allow for easy commit verification and review if needed.
I'll still be using linting locally, so we can expect a return of an
.eslintrcor similar in time, but I'll probably opt for something less opinionated.