Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Admin UI for core field types #5194

Merged
merged 2 commits into from
Mar 23, 2021
+26 −3,719
Merged

Remove legacy Admin UI for core field types #5194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea72552
Remove legacy Admin UI for core field types
timleslie Mar 23, 2021
a3cb5e4
Fix things
emmatown Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/friendly-bottles-scream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystone-ui/core': patch
---

Added missing `@emotion` dependency.
5 changes: 5 additions & 0 deletions .changeset/red-vans-visit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystone-next/fields-legacy': major
---

Removed legacy Admin UI views.
1 change: 1 addition & 0 deletions design-system/packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
},
"dependencies": {
"@babel/runtime": "^7.13.10",
"@emotion/cache": "^10.0.27",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting CI failures in the document field and the docs-next page. It seems like these was an implicit dependency being provided by one of the @arch-ui packages, which I traced back this far.

Not sure if this is the right solution, but so far it seems to at least make our tests pass 🤷‍♂️ .

"@emotion/react": "11.1.5",
"facepaint": "^1.2.1"
},
Expand Down
4 changes: 0 additions & 4 deletions packages/fields/Controller/package.json
View file
Open in desktop

This file was deleted.

38 changes: 1 addition & 37 deletions packages/fields/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,13 @@
},
"dependencies": {
"@apollo/client": "^3.3.12",
"@arch-ui/alert": "^0.0.19",
"@arch-ui/button": "^0.0.23",
"@arch-ui/controls": "^0.1.10",
"@arch-ui/day-picker": "^1.0.6",
"@arch-ui/drawer": "^0.0.26",
"@arch-ui/fields": "^3.0.6",
"@arch-ui/filters": "^0.0.21",
"@arch-ui/input": "^0.1.12",
"@arch-ui/layout": "^0.2.15",
"@arch-ui/loading": "^0.0.19",
"@arch-ui/lozenge": "^0.0.18",
"@arch-ui/options": "^0.0.25",
"@arch-ui/popout": "^0.0.24",
"@arch-ui/select": "^0.1.10",
"@arch-ui/theme": "^0.0.12",
"@arch-ui/tooltip": "^0.1.15",
"@arch-ui/typography": "^0.0.19",
"@babel/runtime": "^7.13.10",
"@emotion/core": "^10.1.1",
"@keystone-next/access-control-legacy": "^9.0.0",
"@keystone-next/adapter-knex-legacy": "^13.2.2",
"@keystone-next/adapter-mongoose-legacy": "^11.1.2",
"@keystone-next/adapter-prisma-legacy": "^4.0.0",
"@keystone-next/server-side-graphql-client-legacy": "^2.0.1",
"@keystone-next/utils-legacy": "^7.0.0",
"@primer/octicons-react": "^11.3.0",
"@sindresorhus/slugify": "^1.1.0",
"apollo-errors": "^1.9.0",
"bcryptjs": "^2.4.3",
Expand All @@ -47,21 +28,11 @@
"decimal.js": "^10.2.1",
"dumb-passwords": "^0.2.1",
"graphql": "^15.5.0",
"image-extensions": "^1.1.0",
"inflection": "^1.12.0",
"intersection-observer": "^0.12.0",
"lodash.groupby": "^4.6.0",
"lodash.isequal": "^4.5.0",
"luxon": "^1.26.0",
"mongoose": "^5.12.1",
"p-settle": "^4.1.1",
"prop-types": "^15.7.2",
"react": "^17.0.1",
"react-day-picker": "8.0.0-beta.3",
"react-dom": "^17.0.1",
"react-image": "^4.0.3",
"react-select": "^4.3.0",
"react-toast-notifications": "^2.4.3"
"p-settle": "^4.1.1"
},
"devDependencies": {
"@keystone-next/app-static-legacy": "*",
Expand All @@ -70,12 +41,5 @@
"globby": "^11.0.3",
"graphql-upload": "^11.0.0",
"mime": "^2.5.2"
},
"preconstruct": {
"entrypoints": [
"index.js",
"Controller.js",
"types/*/views/{Cell,Controller,Filter,Field}.js"
]
}
}
142 changes: 0 additions & 142 deletions packages/fields/src/Controller.js
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/fields/src/resolve-view.js
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions packages/fields/src/types/CalendarDay/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { resolveView } from '../../resolve-view';
import {
CalendarDay,
MongoCalendarDayInterface,
Expand All @@ -9,12 +8,6 @@ import {
export default {
type: 'CalendarDay',
implementation: CalendarDay,
views: {
Controller: resolveView('types/CalendarDay/views/Controller'),
Field: resolveView('types/CalendarDay/views/Field'),
Filter: resolveView('types/CalendarDay/views/Filter'),
Cell: resolveView('types/CalendarDay/views/Cell'),
},
adapters: {
mongoose: MongoCalendarDayInterface,
knex: KnexCalendarDayInterface,
Expand Down
15 changes: 0 additions & 15 deletions packages/fields/src/types/CalendarDay/views/Cell.js
View file
Open in desktop

This file was deleted.

59 changes: 0 additions & 59 deletions packages/fields/src/types/CalendarDay/views/Controller.js
View file
Open in desktop

This file was deleted.

Loading