Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy Admin UI for core field types #5194

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Remove legacy Admin UI for core field types #5194

merged 2 commits into from
Mar 23, 2021

Conversation

timleslie
Copy link
Contributor

See #5025.

Third in the series to remove legacy field views.

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: a3cb5e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@keystone-next/fields-legacy Major
@keystone-next/auth-password-legacy Patch
@keystone-next/fields-authed-relationship-legacy Patch
@keystone-next/fields-auto-increment-legacy Patch
@keystone-next/fields-cloudinary-image-legacy Patch
@keystone-next/fields-color-legacy Patch
@keystone-next/fields-location-google-legacy Patch
@keystone-next/fields-markdown-legacy Patch
@keystone-next/fields-mongoid-legacy Patch
@keystone-next/fields-oembed-legacy Patch
@keystone-next/fields-unsplash-legacy Patch
@keystone-next/fields-wysiwyg-tinymce-legacy Patch
@keystone-next/list-plugins-legacy Patch
@keystone-next/api-tests-legacy Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/fields-document Patch
@keystone-next/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/3bdHdzkZAquSzVw12tohK4M5yvb9
✅ Preview: https://keystone-next-docs-git-remove-core-views-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview March 23, 2021 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 05:20 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 21:32 Inactive
@timleslie timleslie changed the title [WIP] Remove legacy Admin UI for core field types Remove legacy Admin UI for core field types Mar 23, 2021
@vercel vercel bot temporarily deployed to Preview March 23, 2021 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 21:59 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 23, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a3cb5e4:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:09 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:16 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:31 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:34 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:38 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:45 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:52 Inactive
@timleslie timleslie enabled auto-merge (squash) March 23, 2021 22:52
@vercel vercel bot temporarily deployed to Preview March 23, 2021 22:57 Inactive
@emmatown emmatown disabled auto-merge March 23, 2021 23:02
emmatown
emmatown reviewed Mar 23, 2021
View reviewed changes
design-system/packages/core/package.json Outdated
@@ -16,6 +16,7 @@
},
"dependencies": {
"@babel/runtime": "^7.13.10",
"@emotion/cache": "^10.0.27",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting CI failures in the document field and the docs-next page. It seems like these was an implicit dependency being provided by one of the @arch-ui packages, which I traced back this far.

Not sure if this is the right solution, but so far it seems to at least make our tests pass 🤷‍♂️ .

@vercel vercel bot temporarily deployed to Preview March 23, 2021 23:22 Inactive
@timleslie timleslie merged commit a8be4c8 into master Mar 23, 2021
@timleslie timleslie deleted the remove-core-views branch March 23, 2021 23:44
@keystonejs-release-bot keystonejs-release-bot mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

@JedWatson JedWatson JedWatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timleslie @JedWatson @emmatown