Remove createitems #3302
Merged
Remove createitems #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: b784881 We got this. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
singhArmani
force-pushed
the
remove-keysnot-createitems
branch
2 times, most recently
from
d992b92 to
469fe60
Compare
timleslie
suggested changes
Jul 29, 2020
| @@ -2,7 +2,11 @@ const runQuery = async ({ keystone, query, variables, context }) => { | |||
| const { data, errors } = await keystone.executeGraphQL({ | |||
| context: | |||
| context || | |||
| keystone.createContext({ schemaName: 'public', authentication: {}, skipAccessControl: true }), | |||
| keystone.createContext({ | |||
There was a problem hiding this comment.
This file shouldn't have changed.
There was a problem hiding this comment.
I think it happens due to yarn format. 🤔
yarn.lock
Outdated
| version "2.3.0" | ||
| resolved "https://registry.yarnpkg.com/apollo-engine-reporting/-/apollo-engine-reporting-2.3.0.tgz#3bb59f81aaf6b967ed098896a4a60a053b4eed5a" | ||
| integrity sha512-SbcPLFuUZcRqDEZ6mSs8uHM9Ftr8yyt2IEu0JA8c3LNBmYXSLM7MHqFe80SVcosYSTBgtMz8mLJO8orhYoSYZw== | ||
| apollo-engine-reporting@^2.2.1: |
There was a problem hiding this comment.
This file shouldn't have changed.
singhArmani
force-pushed
the
remove-keysnot-createitems
branch
2 times, most recently
from
c40b816 to
5ee1392
Compare
timleslie
suggested changes
Jul 29, 2020
.changeset/hot-olives-reply.md
Outdated
| '@keystonejs/keystone': major | ||
| --- | ||
|
|
||
| Removed the `keystone.createItems` method. This has been replaced with the `createItems` function in `@keystonejs/server-side-graphql-client`. |
There was a problem hiding this comment.
We should also mention that we removed keystone.createItem.
| @@ -74,284 +74,3 @@ module.exports = { | |||
| ``` | |||
|
|
|||
| > **Tip:** A similar setup can be achieved by running the Keystone CLI `yarn create keystone-app` and selecting `Starter (Users + Authentication)`. This starter project has a `User` list, `PasswordAuthStrategy` and seeding of the database already configured. For now, we will proceed manually. | |||
|
|
|||
There was a problem hiding this comment.
Removing this documentation has rendered this document useless. We should replace the old content with new content which refers to the server-side-graphql-client package. It needn't be as verbose as this content was, since we aren't describing a new APi, but this tutorial should continue to serve a purpose.
Closed
singhArmani
force-pushed
the
remove-keysnot-createitems
branch
from
9cfd5a4 to
55d7ef1
Compare
timleslie
reviewed
Jul 30, 2020
timleslie
suggested changes
Jul 30, 2020
- add seeding tutorials - remove relationship-utils module - remove leftover `createItem` usage in the docs
singhArmani
force-pushed
the
remove-keysnot-createitems
branch
from
d943e0f to
2ce474b
Compare
singhArmani
force-pushed
the
remove-keysnot-createitems
branch
from
2ce474b to
b784881
Compare
This was referenced Jul 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final PR in series, needs to be merged after #3300 and #3129
This is breaking and should probably be shipped after people have had time to make changes based on the above 2 PRs.