Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all internal uses of createItems #3301

Merged
merged 12 commits into from
Jul 29, 2020
Merged

Conversation

MadeByMike
Copy link
Contributor

This should be merged after #3300. Should result in no functional changes.

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2020

🦋 Changeset is good to go

Latest commit: e920dd7

We got this.

This PR includes changesets to release 9 packages
Name Type
@keystonejs/api-tests Patch
@keystonejs/demo-project-blog Patch
@keystonejs/demo-project-meetup Patch
@keystonejs/server-side-graphql-client Patch
@keystonejs/cypress-project-access-control Patch
@keystonejs/cypress-project-basic Patch
@keystonejs/cypress-project-client-validation Patch
@keystonejs/cypress-project-login Patch
@keystonejs/cypress-project-social-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@singhArmani singhArmani force-pushed the update-tests-to-use-ssgqlc branch from 556c43f to e447c93 Compare July 28, 2020 05:25
@timleslie timleslie changed the title Update all internal uses of createItems [WIP] Update all internal uses of createItems Jul 28, 2020
@MadeByMike MadeByMike changed the title [WIP] Update all internal uses of createItems Update all internal uses of createItems Jul 28, 2020
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the changes in initial-data.md reverted and then I think this is 👍

@MadeByMike MadeByMike requested a review from timleslie July 28, 2020 07:57
@singhArmani singhArmani force-pushed the update-tests-to-use-ssgqlc branch from 461cf01 to e920dd7 Compare July 29, 2020 00:26
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@singhArmani singhArmani merged commit acaf19c into master Jul 29, 2020
@singhArmani singhArmani deleted the update-tests-to-use-ssgqlc branch July 29, 2020 04:44
This was referenced Jul 29, 2020
@timleslie timleslie mentioned this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants