Better error messages when unique validation fails (mongodb) #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 9d685ad We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vultraz
force-pushed
the
mongoose-error-unique
branch
from
3f43399 to
aff3a7b
Compare
|
Thanks Charles you're on fire! This is good but won't close #433 as I believe that's more about having a visual indication in the UI. |
|
Looks like this breaks one of our CI test :( |
Vultraz
force-pushed
the
mongoose-error-unique
branch
5 times, most recently
from
0fb6f8d to
6ce5774
Compare
|
@MadeByMike Fixed (besides the unrelated random failure)! Also fixed the deprecation warning about |
Fixes this warning: testResultsProcessor support is deprecated. Please use jest reporter. See https://github.com/jest-community/jest-junit#usage:
Vultraz
force-pushed
the
mongoose-error-unique
branch
from
6ce5774 to
3e43113
Compare
Vultraz
changed the title
MadeByMike
approved these changes
Oct 31, 2019
This was referenced Oct 31, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #433 since the error appears.
This utilizes mongoose-unique-validator as a global schema plugin. Test done with a unique URL field.
Before
After
