Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface isUnique constraint errors in Admin UI #433

Closed
jesstelford opened this issue Oct 11, 2018 · 5 comments · Fixed by #1857
Closed

Surface isUnique constraint errors in Admin UI #433

jesstelford opened this issue Oct 11, 2018 · 5 comments · Fixed by #1857

Comments

@jesstelford
Copy link
Contributor

Dependent on #431

When attempting to create an item which violates a unique constraint, the Admin UI does not surface any errors:

unique-no-error

Similarly for update mutations.

@molomby
Copy link
Member

molomby commented Oct 11, 2018

Relates to #245. We need a way of bubbling errors and validation messages up from the adapter/hooks/etc. out into the admin UI.

@molomby
Copy link
Member

molomby commented Oct 19, 2018

Fyi, there are docs coming on how this stuff will work. Don't jump in and fix this without speaking to me please! :)

@timleslie timleslie changed the title Surface unique constraint errors in Admin UI Surface isUnique constraint errors in Admin UI Dec 7, 2018
@dcousens dcousens added the bug label May 14, 2019
@MadeByMike MadeByMike mentioned this issue Sep 17, 2019
13 tasks
@molomby molomby reopened this Jan 30, 2020
@molomby
Copy link
Member

molomby commented Jan 30, 2020

#1857 fixed this for Mongo, not generally. We still get ugly messages on the Knex adapter:

Screenshot 2020-01-30 at 11 11 24

This is also an example of a much further reaching security issue whereby GraphQL errors leak system internals (#2303).

@stale
Copy link

stale bot commented May 29, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@bladey
Copy link
Contributor

bladey commented Apr 8, 2021

Keystone 5 has officially moved into active maintenance mode as we push towards the next major new version Keystone Next, you can find out more information about this transition here.

In an effort to sustain the project going forward, we're cleaning up and closing old issues such as this one. If you feel this issue is still relevant for Keystone Next, please let us know.

@bladey bladey closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants