Add _req_user to removed item so you can use this in the remove pre/p… #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost hook As discussed in keystonejs/keystone#1857 the remove pre/post hooks are "missing" the _req_user. I, amongst others, am using this object to handle some permissions. It's available in the updateHandler (in `create` and `update`) but missing in `remove`. it's added on the updateHandler here: https://github.com/keystonejs/keystone/blob/d34f45662eb359e2cb18b397f2ffea21f9883141/lib/list/updateItem.js#L157 Remove doesn't use the updateHandler, so this is missing.
|
this seems like a worthwhile addition, and would be consistent with the other hooks. My concern is that a larger change seemed pending in #3187, but discussion died. I'd like to think this change is independent of #3187, and to prevent a breaking change, both options should live side by side, however, I'd feel more comfortable if @dominikwilkowski or @JedWatson weighed in before continuing. |
|
Would be great if we could get this PR sorted. I am sure many like me are awaiting this value to settle permissions on deleting records. A simple line of code, endless possibilities :D |
JedWatson
approved these changes
Apr 5, 2019
|
Thanks @laurenskling. Sorry this went unmerged for so long, will push a new release with the fix this weekend. |
|
Awesome @JedWatson thanks so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ost hook
As discussed in keystonejs/keystone#1857 the remove pre/post hooks are "missing" the _req_user. I, amongst others, am using this object to handle some permissions. It's available in the updateHandler (in
createandupdate) but missing inremove.it's added on the updateHandler here: https://github.com/keystonejs/keystone/blob/d34f45662eb359e2cb18b397f2ffea21f9883141/lib/list/updateItem.js#L157
Remove doesn't use the updateHandler, so this is missing.
Description of changes
Related issues (if any)
Testing
npm run test-allran successfully.