-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge master into linux-mcompile 🐘 #9643
Merged
mcdurdin
merged 89 commits into
epic/linux-mcompile
from
chore/merge-master-into-linux-mcompile
Oct 3, 2023
Merged
chore: merge master into linux-mcompile 🐘 #9643
mcdurdin
merged 89 commits into
epic/linux-mcompile
from
chore/merge-master-into-linux-mcompile
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around npm/cli#3466 when bundling internal dependencies using the bundleDependencies package.json property. This change works in tandem with the npm pack/publish process -- when we run `developer/src/kmc/build.sh publish` (or `pack`), we end up with `npm version` stomping on all our package.json files, so the repo is dirty after this. We need a copy of the top-level package.json before this stomping happens, in order to get a simple map of the location of each of our internal dependencies, from the `dependencies` property (it would be possible to figure this out with a lot more parsing of our package.json files, but this is simpler). This means, in future, we should avoid publishing our internal dependencies such as those under common/ to npm, as they serve no practical purpose there.
Fixes #9546. Previously, a new project would include both mobile and tablet platform in the touch layout file. However, the majority of devs want to work with just one, so this removes the tablet platform. Adding a new platform is a single click within the editor, which duplicates the current platform as a starting point.
- unicode-org/cldr:61b74a36de8329daed152005133a699ae7f2012b - for feat(core): ldml drop \u1234 format 🙀 #9515
This change improves the startup method so that it will also work if ibus hasn't started yet. Also fixes two memory leaks.
- for now, convert \u{1234} to \u1234 before going into UnicodeSet. - for feat(core): ldml drop \u1234 format 🙀 #9515
- temporarily roll back change to test.xml - for feat(core): ldml drop \u1234 format 🙀 #9515
- fix 1..6 char Unicode escapes with an unrolled loop - for feat(core): ldml drop \u1234 format 🙀 #9515
refactor(linux): Reformat file
auto: increment master version to 17.0.175
chore(linux): Split startup process
auto: increment master version to 17.0.176
- unicode-org/cldr:bd40148d4c8675d0fb2db8c36cfb9f8e328250a8
github-actions
bot
added
ios/
mac/
linux/
common/
developer/compilers/
common/resources/
Build infrastructure
oem/
android/engine/
android/app/
ios/app/
ios/engine/
linux/config/
linux/engine/
core/
Keyman Core
common/web/
developer/ide/
oem/fv/
oem/fv/android/
windows/config/
docs
chore
labels
Sep 29, 2023
darcywong00
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rslgtm
RSLGTM |
Don't close the PR 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android/app/
android/engine/
android/
chore
common/resources/
Build infrastructure
common/web/
common/
core/
Keyman Core
developer/compilers/
developer/ide/
developer/
docs
epic-linux-mcompile
ios/app/
ios/engine/
ios/
linux/config/
linux/engine/
linux/
mac/
oem/fv/android/
oem/fv/
oem/
web/
windows/config/
windows/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip