Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify example for builder_describe_internal_dependency in build-utils.md #9581

Closed
ermshiperete opened this issue Sep 18, 2023 · 2 comments · Fixed by #9582
Closed

docs: Clarify example for builder_describe_internal_dependency in build-utils.md #9581

ermshiperete opened this issue Sep 18, 2023 · 2 comments · Fixed by #9582
Labels
common/ docs
Milestone
A17S22

Comments

@ermshiperete
Copy link
Contributor

ermshiperete commented Sep 18, 2023 •
edited
Loading

It seems to me that the example for builder_describe_internal_dependency in build-utils.md and builder.inc.sh is wrong.

Shouldn't this be the following?

builder_describe_internal_dependency \
  build:mac build:mac-x86_64 \
  build:mac build:mac-arm64
@ermshiperete ermshiperete added this to the A17S22 milestone Sep 18, 2023
ermshiperete added a commit that referenced this issue Sep 18, 2023
@ermshiperete
docs(common): Fix documentation for builder_describe_internal_dependency
1e734a4 
Fixes #9581.
@ermshiperete
Copy link
Contributor Author

core/build.sh shows that the documentation is in deed wrong.

@ermshiperete ermshiperete mentioned this issue Sep 18, 2023
Merged
@mcdurdin
Copy link
Member

🤦🏼 my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
common/ docs
Projects
None yet
Milestone
A17S22
Development

Successfully merging a pull request may close this issue.

docs(common): Fix documentation for builder_describe_internal_dependency keymanapp/keyman
2 participants
@ermshiperete @mcdurdin