Admin next layout #773
Merged
Admin next layout #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
force-pushed
the
admin-next-layout
branch
from
40710ff
to
7325e94
Compare
…urrently a top bar)
…ing the admin next client
kevinhughes27
force-pushed
the
admin-next-layout
branch
from
e213501
to
c9b9813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #750
Couple of notes so far - Typescript is pretty annoying. I haven't seen anything super helpful from it yet either. I've tamed it for now but I forsee issues when adding Relay so it might have to go.
JSS was annoying at first but mostly because it was sprinkled everywhere. I pulled all the style hashes to their own file so the component files are simpler and now I don't mind it.