Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Next #750

Closed
16 of 20 tasks
kevinhughes27 opened this issue Mar 19, 2018 · 0 comments · Fixed by #868
Closed
16 of 20 tasks

Admin Next #750

kevinhughes27 opened this issue Mar 19, 2018 · 0 comments · Fixed by #868
Labels

Comments

@kevinhughes27
Copy link
Owner

kevinhughes27 commented Mar 19, 2018

A new admin client built with react, relay, typescript with GraphQL for the backend

  • client (react on rails) will go away
  • all clients will live in the clients folder and will be self sufficient in terms of development. They will be built on their own and then served by rails in production

Matthieu Segret wrote an example blog using more or less the exact architecture I am imagining here: https://github.com/MatthieuSegret/graphql-rails-blog

Why?

Rails is an excellent framework for interacting with a database and building backends however in my opinion Rails frontend is inadequate for building a rich user experience. Attempts to integrate Rails with modern frontend technologies (like react_on_rails) add significant complexity to Rails when two separate toolchains would be simpler.

GraphQL is the new hottness in API design and for good reason. Its more opinionated and strongly typed compared to Rails controllers and RESTful APIs plus it automatically documents itself. Long term a backend only API is a lot easier to maintain and more flexible in terms of how we productize the app.

ToDo

Post 🚢 Cleanup

  • remove the non-global ID fields from the API. Old Schedule Editor uses fieldId and team controller uses divisionId
  • remove a few workarounds in mutations resolvers for the old admin. There are comments showing these
  • remove force param from updateScore and resolver
This was referenced Nov 7, 2018
This was referenced Nov 15, 2018
This was referenced Nov 22, 2018
@kevinhughes27 kevinhughes27 mentioned this issue Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant