-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcrpy throws an error if latest urllib3 is installed #688
vcrpy throws an error if latest urllib3 is installed #688
Comments
You can use |
vcrpy does not use urllib3 correctly. Pin urllib3 until kevin1024/vcrpy#688 is fixed.
vcrpy does not use urllib3 correctly. Pin urllib3 until kevin1024/vcrpy#688 is fixed.
Related: urllib3/urllib3#3017 |
I'm having the same issue, the issue appears to be that VERIFIEDHTTPSConnection is imported from connectionpool in vcr. But that is not where its declared but rather a place in urllib3 that used to import VERIFIEDHTTPSConnection as well. |
vcrpy does not use urllib3 correctly. Pin urllib3 until kevin1024/vcrpy#688 is fixed. Needed a hack in the "Install dependencies" step to work around a build failure on Windows: for some reason the Windows builder still had urllib 2.0.2 installed. Could not reproduce this in my Windows VM so I suspect there is a bug in the way the setup-python GitHub action works.
vcrpy does not use urllib3 correctly. Pin urllib3 until kevin1024/vcrpy#688 is fixed. Needed a hack in the "Install dependencies" step to work around a build failure on Windows: for some reason the Windows builder still had urllib 2.0.2 installed. Could not reproduce this in my Windows VM so I suspect there is a bug in the way the setup-python GitHub action works.
Tests are currently failing due to kevin1024/vcrpy#688. This PR temporarily pins the urllib3 version to <2 until there is a new release of vcrpy.
Upstream issue: kevin1024/vcrpy#688 Signed-off-by: Horea Christian <[email protected]>
This shouldn't affect the wheel metadata, so we can make a new release without issue.
Since urllib3 v2 the re-export of connection.HTTPConnection in urllib3.connectionpool was removed. In this commit we use urllib3.connection where needed. Some references to connectionpool.HTTPConnection are still there for backward compatibility. Closes #688
This shouldn't affect the wheel metadata, so we can make a new release without issue.
Since urllib3 v2 the re-export of connection.HTTPConnection in urllib3.connectionpool was removed. In this commit we use urllib3.connection where needed. Some references to connectionpool.HTTPConnection are still there for backward compatibility. Closes #688
@kevin1024 can this issue stay open until the python<3.10 problem is worked out? |
@fiendish PS: We welcome help allowing support for Python <3.10 with urllib3 v2 installed if you have ideas how. Comment #699 (comment) and after document how far we got economically in more detail. |
@hartwork It's a procedural request, not a technical one. people reference this issue when discussing the problem with their builds, and the problem isn't fixed for urllib3v2 + py3.9. I've had requests already asking why particular urllib updates are blocked because the issue looks resolved until you go to the release notes.
At the time I don't. I wish I did. |
Hi @fiendish I'm in a bit of a conflict here, maybe you can help me with that, let me explain. Issue "vcrpy throws an error if latest urllib3 is installed" is impossible to happen for both the latest release and Git @jairhenrique @kevin1024 please be invited to join in with your view on this, I have no intentions to misrepresent my view on this as the view of the whole team if it's not. |
New ticket specifically about urllib3 v2 with Python <3.10 makes sense to me |
I think this depends on what one means by "latest" and "impossible". urllib3<2 is of course not the latest urllib3. And it of course is possible by upgrading urllib3 after vcrpy is installed. Though the problem does not manifest at import time. But I recognize your dilemma and can just continue pointing people to the reason given outside of this github issue. |
Also, thank you both for the fair consideration. I do appreciate the responses. |
@fiendish I only considered combinations that would pass |
See more info at - urllib3/urllib3#3017 - kevin1024/vcrpy#688
vcrpy won't import with latest urllib.
The text was updated successfully, but these errors were encountered: