Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin urllib3 #14525

Merged
merged 1 commit into from
May 5, 2023
Merged

Pin urllib3 #14525

merged 1 commit into from
May 5, 2023

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented May 5, 2023 •
edited
Loading

What does this PR do?

vcrpy currently cannot use the latest version of urllib3 (v2.0.0 and up) due to the following error:

AttributeError: module 'urllib3.connectionpool' has no attribute 'VerifiedHTTPSConnection'

This pin can be removed once vcrpy fixes this bug.

Motivation

Failing CI: https://github.com/DataDog/integrations-core/actions/runs/4894505518/jobs/8738847769

Additional Notes

vcrpy Github issue: kevin1024/vcrpy#688
urllib3 changelog: https://urllib3.readthedocs.io/en/stable/changelog.html

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@yzhan289 yzhan289 requested a review from a team as a code owner May 5, 2023 14:37
@github-actions
Copy link

github-actions bot commented May 5, 2023

Test Results

    2 files      2 suites   1m 16s ⏱️
233 tests 228 ✔️   5 💤 0 ❌
466 runs  446 ✔️ 20 💤 0 ❌

Results for commit 129d792.

@yzhan289 yzhan289 merged commit ccf0334 into master May 5, 2023
@yzhan289 yzhan289 deleted the az/pin-urllib3 branch May 5, 2023 16:09
aweaver89 pushed a commit that referenced this pull request May 10, 2023
@yzhan289
Pin urllib3 (#14525)
a1ca888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog ddev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhan289 @iliakur