Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Pipfile, remove requirements already stated in setup.py #143

Closed
wants to merge 5 commits into from

Conversation

vlcinsky
Copy link
Contributor

@vlcinsky vlcinsky commented Apr 4, 2018

Btw the change revealed, that setup.py was not requiring pendulum>=1.0
(the version was not present).

Fix #142

@vlcinsky
Copy link
Contributor Author

vlcinsky commented Apr 4, 2018

Any idea what is going on? pipenv claims that in the kennethreitz/maya are no files, but the files are there, possibly it expects some specific files. Or there is a bug in pipenv.

@vlcinsky
Copy link
Contributor Author

vlcinsky commented Apr 4, 2018

The PR concept follows final advice from pypa/pipenv#1263

But I still have no idea, why it fails.

tzlocal = "*"
pendulum = ">=1.0"
snaptime = "*"
"e1839a8" = {path = ".", editable = true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because it doesn't work. The hash used here was just an example in pypa/pipenv#1263 (comment)

- pip install pipenv
- pipenv --version
- pwd
- ls -l
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of debugging stuff here ..

@timofurrer
Copy link
Collaborator

I guess @kennethreitz should have an answer on how to handle this. Because from what I've read from pypa/pipenv#1263 I'm pretty confused myself. The best practice suggestion isn't in the docs. I assume a lot of people still have the same confusion.

@kennethreitz Can you elaborate on that a bit an suggest how to handle it in maya correctly?

@timofurrer timofurrer requested a review from kennethreitz April 4, 2018 18:18
@timofurrer
Copy link
Collaborator

I'm going to close this one in favor of #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants