-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Pipfile, remove requirements already stated in setup.py #143
Conversation
Btw the change revealed, that setup.py was not requiring pendulum>=1.0 (the version was not present).
Any idea what is going on? |
The PR concept follows final advice from pypa/pipenv#1263 But I still have no idea, why it fails. |
tzlocal = "*" | ||
pendulum = ">=1.0" | ||
snaptime = "*" | ||
"e1839a8" = {path = ".", editable = true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because it doesn't work. The hash used here was just an example in pypa/pipenv#1263 (comment)
- pip install pipenv | ||
- pipenv --version | ||
- pwd | ||
- ls -l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a lot of debugging stuff here ..
I guess @kennethreitz should have an answer on how to handle this. Because from what I've read from pypa/pipenv#1263 I'm pretty confused myself. The best practice suggestion isn't in the docs. I assume a lot of people still have the same confusion. @kennethreitz Can you elaborate on that a bit an suggest how to handle it in maya correctly? |
I'm going to close this one in favor of #144 |
Btw the change revealed, that setup.py was not requiring pendulum>=1.0
(the version was not present).
Fix #142