Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required packages declare in setup.py and Pipfile - dangerous redundancy #142

Closed
vlcinsky opened this issue Apr 4, 2018 · 0 comments
Closed

Comments

@vlcinsky
Copy link
Contributor

vlcinsky commented Apr 4, 2018

Packages required by maya are now declared in setup.py but also in Pipfile (Pipfile.lock which gets generated on the way is out of scope).

tox tests are often great mean to detect broken requirements (such as omitted package). However, current status can easily hide such problem as a package omitted in setup.py may be installed via Pipfile declaration.

I think, proper solution is:

  • remove all non-dev requirements from Pipfile and keep there only editable requirement for current package.
  • maintain package requirements only within setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant