Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove probably obsolete requirement for ruamel.yaml #136

Merged
merged 2 commits into from
Apr 4, 2018

Conversation

vlcinsky
Copy link
Contributor

See issue #134

@timofurrer
Copy link
Collaborator

@kennethreitz why are we using ruamel.yaml ? I've noticed that dateparser is using ruamel.yaml but when is this warning raised which we are ignoring?

@vlcinsky vlcinsky force-pushed the remove_ruamel branch 2 times, most recently from f8e7df0 to 4487da8 Compare April 3, 2018 21:43
@asadurski
Copy link

@timofurrer dateparser dropped dependency on ruamel.yaml in recent version 0.7.0 (scrapinghub/dateparser#374).

@timofurrer
Copy link
Collaborator

@asadurski Thanks for the input! I guess we removed it then, too 🎉

@timofurrer
Copy link
Collaborator

@vlcinsky Can you pin the dateparser to versions greater than 0.7.0 ?

@timofurrer timofurrer removed the request for review from kennethreitz April 4, 2018 10:54
@vlcinsky
Copy link
Contributor Author

vlcinsky commented Apr 4, 2018

@timofurrer dateparser pinned as requested.

@timofurrer
Copy link
Collaborator

Great, thanks! I'm going to merge this 🎉

@timofurrer timofurrer merged commit e0e33cc into kennethreitz:master Apr 4, 2018
@benswift
Copy link

Awesome - this has been bugging me for a while as well. Any idea when the sans-ruamel.yaml version will be released to PyPI?

@timofurrer
Copy link
Collaborator

@kennethreitz Can you release, please?

@benswift
Copy link

benswift commented May 8, 2018

ping! any word on a new release?

@timofurrer
Copy link
Collaborator

I've just released v0.4.1 which you can use 🎉

@benswift
Copy link

many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants