Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is package ruamel.yaml really required? #134

Closed
vlcinsky opened this issue Mar 31, 2018 · 1 comment
Closed

is package ruamel.yaml really required? #134

vlcinsky opened this issue Mar 31, 2018 · 1 comment

Comments

@vlcinsky
Copy link
Contributor

setup.py, Pipfile and maya/core.py reference ruamel.yaml but I did not find any direct usage of it in the code.

Is it really needed?

Does it relate to ruamel.ordereddict?

Issue #57 is mentioning ruamel.yaml but there is no clear reason for it.
vlcinsky added a commit to vlcinsky/maya that referenced this issue Mar 31, 2018
@vlcinsky
Remove probably obsolete requirement for ruamel.yaml
8d07142 
See issue kennethreitz#134
vlcinsky added a commit to vlcinsky/maya that referenced this issue Mar 31, 2018
@vlcinsky
Remove probably obsolete requirement for ruamel.yaml
16d1526 
See issue kennethreitz#134
@vlcinsky vlcinsky mentioned this issue Mar 31, 2018
Merged
vlcinsky added a commit to vlcinsky/maya that referenced this issue Apr 3, 2018
@vlcinsky
Remove probably obsolete requirement for ruamel.yaml
f8e7df0 
See issue kennethreitz#134
vlcinsky added a commit to vlcinsky/maya that referenced this issue Apr 3, 2018
@vlcinsky
Remove probably obsolete requirement for ruamel.yaml
4487da8 
See issue kennethreitz#134
vlcinsky added a commit to vlcinsky/maya that referenced this issue Apr 3, 2018
@vlcinsky
Remove probably obsolete requirement for ruamel.yaml
67ebf60 
See issue kennethreitz#134
timofurrer pushed a commit that referenced this issue Apr 4, 2018
@vlcinsky @timofurrer
Remove probably obsolete requirement for ruamel.yaml (#136)
e0e33cc 
* Remove probably obsolete requirement for ruamel.yaml

Closes issue #134

* require dateparser>=0.7.0 (to ensure ruamel.yaml is not really needed)
@timofurrer
Copy link
Collaborator

ruamel.yaml is removed with #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlcinsky @timofurrer