Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: meta tweak #291

Merged
merged 11 commits into from
Feb 2, 2023
Merged

chore: meta tweak #291

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15c96f8
fix: add quiet flag to update-snapshot script
aarondill Feb 2, 2023
f29a2f3
refactor: use long option for ava update-snapshots
aarondill Feb 2, 2023
dc8f40e
refactor: quote pacakge.json in scripts
aarondill Feb 2, 2023
3131ff1
fix: change sort-package-json script to actually sort
aarondill Feb 2, 2023
ec3a799
fix: fix argument passed to npm run sort-package-json
aarondill Feb 2, 2023
0423ea3
style: run Prettier on everything
fisker Feb 2, 2023
5cf1a25
style: quotes in comments
fisker Feb 2, 2023
51fe852
chore: tweak
fisker Feb 2, 2023
464cf1c
refactor: remove sort from `update-snapshots`
fisker Feb 2, 2023
4019beb
test: see how `package.json` works in lint-staged
fisker Feb 2, 2023
6285a9c
chore: lint-stage runs prettier on everything
fisker Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ jobs:
fail-fast: false
matrix:
os:
- "ubuntu-latest"
- 'ubuntu-latest'
# - "macos-latest"
# - "windows-latest"
node_version:
- "18"
- "16"
- "14"
- "12"
- '18'
- '16'
- '14'
- '12'
name: Node.js ${{ matrix.node_version }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -39,7 +39,7 @@ jobs:
run: npm run lint

- name: Check package.json
run: npm run sort-package-json
run: npm run sort-package-json -- --check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

NPM is making things weird, previously -- is not needed, already run into this problem several times.


- name: Run Tests
run: npm run test-coverage
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@
"lint": "eslint .",
"prepare": "husky install",
"semantic-release": "semantic-release",
"sort-package-json": "node cli.js package.json --check",
"sort-package-json": "node cli.js \"package.json\"",
"test": "ava && dtslint --localTs node_modules/typescript/lib",
"test-coverage": "nyc ava",
"update-snapshot": "ava -u && node cli.js package.json"
"update-snapshots": "ava --update-snapshots && node cli.js \"package.json\" --quiet"
},
"commitlint": {
"extends": [
Expand Down