chore: meta tweak #291
Merged
chore: meta tweak #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix returns the output of update-snapshot to the closest to the previous output as is possible. The new increased output takes from the focus of the script.
fisker
reviewed
Feb 2, 2023
|
Maybe we should change - node cli.js package.json
+ node cli.js \"package.json\"To show user that better quote pattern/file s. Because shell may expand glob pattern and get unexpected result. |
Co-authored-by: fisker Cheung <[email protected]>
I could change it to |
|
single quote doesn't work on windows. |
fisker
reviewed
Feb 2, 2023
.github/workflows/pr.yml
Outdated
| @@ -39,7 +39,7 @@ jobs: | |||
| run: npm run lint | |||
|
|
|||
| - name: Check package.json | |||
| run: npm run sort-package-json -- check | |||
| run: npm run sort-package-json -- --check | |||
There was a problem hiding this comment.
Nice catch.
NPM is making things weird, previously -- is not needed, already run into this problem several times.
fisker
changed the title
aarondill
commented
Feb 2, 2023
fisker
reviewed
Feb 2, 2023
fisker
approved these changes
Feb 2, 2023
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix returns the output of
npm run update-snapshotto the closest to the previous output as is possible. The new increased output of cli.js takes from the focus of the script by displaying multiple lines at the end regardless of the state of package.json, so this PR silences the cli, instead sorting the package in the background, potentially even without user awareness.