Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle other Azure Clouds #38

Closed
wahidsaleemi opened this issue Aug 8, 2019 · 4 comments
Closed

Doesn't handle other Azure Clouds #38

wahidsaleemi opened this issue Aug 8, 2019 · 4 comments
Assignees

Comments

@wahidsaleemi
Copy link

Looks like the management endpoint is hard-coded for AzureCloud (Azure Commercial). We tried to use it on AzureUSGovernment (Azure Government) and it was pointing at the wrong management endpoint.

Would be nice if it could handle all the Azure Clouds (Gov, China, Germany, Azure Stack, etc.)

@andrewholler
Copy link
Contributor

andrewholler commented Sep 6, 2019

This is also an issue for our organization to use for AzureChina cloud. I've submitted a PR which you can see below.

@keesschollaart81
Copy link
Owner

Awesome, will release this feature later this week after I ran it for a couple of days agains my ACC ring

@keesschollaart81 keesschollaart81 mentioned this issue Sep 8, 2019
Merged
@keesschollaart81 keesschollaart81 self-assigned this Sep 9, 2019
keesschollaart81 added a commit that referenced this issue Sep 15, 2019
- Doesn't handle other Azure Clouds #38
- Task v5 fails if there is no output #25
- Updated dependencies of Azure SDK's
@keesschollaart81
Copy link
Owner

This should now be available in production. I don't have access to other clouds than the normal Azure one so please test for me if it works!

@andrewholler
Copy link
Contributor

andrewholler commented Sep 16, 2019

Please reopen. Unfortunately because I was not able to test locally, there was a piece missing to work with other Azure clouds. I have since setup private extension testing and fixed the issue. I initially skipped adding multi-cloud configuration to the ResourceManagementClient. I had assumed that it would get environment information from the passed credentials but that assumption was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants