-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't handle other Azure Clouds #38
Comments
This is also an issue for our organization to use for AzureChina cloud. I've submitted a PR which you can see below. |
Awesome, will release this feature later this week after I ran it for a couple of days agains my ACC ring |
This should now be available in production. I don't have access to other clouds than the normal Azure one so please test for me if it works! |
Please reopen. Unfortunately because I was not able to test locally, there was a piece missing to work with other Azure clouds. I have since setup private extension testing and fixed the issue. I initially skipped adding multi-cloud configuration to the ResourceManagementClient. I had assumed that it would get environment information from the passed credentials but that assumption was wrong. |
Looks like the management endpoint is hard-coded for AzureCloud (Azure Commercial). We tried to use it on AzureUSGovernment (Azure Government) and it was pointing at the wrong management endpoint.
Would be nice if it could handle all the Azure Clouds (Gov, China, Germany, Azure Stack, etc.)
The text was updated successfully, but these errors were encountered: