Skip a few Passkeys tests with Botan <= 2.14 #10360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
changed the title
varjolintu
force-pushed
the
fix/passkeys_botan2_bug_skip_tests
branch
from
82b9356 to
41b9aa5
Compare
droidmonkey
approved these changes
Mar 8, 2024
droidmonkey
added a commit
that referenced
this pull request
Mar 9, 2024
Botan version less than 2.14.0 miscalculates ECDSA signatures. --------- Co-authored-by: Jonathan White <[email protected]>
droidmonkey
added a commit
that referenced
this pull request
Mar 9, 2024
Botan version less than 2.14.0 miscalculates ECDSA signatures. --------- Co-authored-by: Jonathan White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Botan 2.12 is still included in some older distros, and creating a signature will fail because of: randombit/botan#2293.
For now, disable a few tests if the Botan version is older than 2.14 that includes the fix.
Type of change