Skip a few Passkeys tests with Botan <= 2.14 (#10360)

Botan version less than 2.14.0 miscalculates ECDSA signatures. --------- Co-authored-by: Jonathan White <[email protected]>
keepassxreboot · Mar 9, 2024 · 3c67600 · 3c67600
1 parent 267b33e
commit 3c67600
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/tests/TestPasskeys.cpp b/tests/TestPasskeys.cpp
@@ -194,6 +194,9 @@ void TestPasskeys::testDecodeResponseData()
 
 void TestPasskeys::testLoadingECPrivateKeyFromPem()
 {
+#if BOTAN_VERSION_CODE < BOTAN_VERSION_CODE_FOR(2, 14, 0)
+    QSKIP("ECDSA Signature is broken on Botan < 2.14.0");
+#endif
     const auto publicKeyCredentialRequestOptions =
         browserMessageBuilder()->getJsonObject(PublicKeyCredentialRequestOptions.toUtf8());
     const auto privateKeyPem = QString("-----BEGIN PRIVATE KEY-----"
@@ -412,6 +415,9 @@ void TestPasskeys::testRegister()
 
 void TestPasskeys::testGet()
 {
+#if BOTAN_VERSION_CODE < BOTAN_VERSION_CODE_FOR(2, 14, 0)
+    QSKIP("ECDSA Signature is broken on Botan < 2.14.0");
+#endif
     const auto privateKeyPem = QString("-----BEGIN PRIVATE KEY-----"
                                        "MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQg5DX2R6I37nMSZqCp"
                                        "XfHlE3UeitkGGE03FqGsdfxIBoOhRANCAAQG7K80W2KRYW0ZWQOmUCrKMcSVqGnl"

diff --git a/tests/TestPasskeys.h b/tests/TestPasskeys.h
@@ -18,9 +18,9 @@
 #ifndef KEEPASSXC_TESTPASSKEYS_H
 #define KEEPASSXC_TESTPASSKEYS_H
 
-#include <QObject>
-
 #include "browser/BrowserPasskeys.h"
+#include <QObject>
+#include <botan/version.h>
 
 class TestPasskeys : public QObject
 {