Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bump Blockifier to 0.8.0-rc.3 #345

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

odesenfans
Copy link
Contributor

@odesenfans odesenfans commented Sep 4, 2024

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@odesenfans odesenfans requested a review from notlesh as a code owner September 4, 2024 16:42
Copy link
Collaborator

@HermanObst HermanObst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -28,7 +28,7 @@ assert_matches = "1.5.0"
base64 = "0.21.3"
bitvec = { version = "1.0.1", features = ["serde"] }
# Point to the latest commit of branch msl/snos-0.6.0-rc.2
blockifier = { git = "https://github.com/Moonsong-Labs/sequencer", rev = "01b97d9354faefa5f0cd520b5efbe73178213f7e", features = ["testing"] }
blockifier = { git = "https://github.com/Moonsong-Labs/sequencer", rev = "6624e910c57db9a16f1607c1ed26f7d8f1114e73", features = ["testing"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually point to the latest commit of branch
backport-secp-patches-0.8.0-rc.3 :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, fixing

@odesenfans odesenfans merged commit f03680b into main Sep 4, 2024
6 checks passed
@odesenfans odesenfans deleted the od/chore-bump-to-blockifier-0.8.0-rc.3 branch September 4, 2024 20:54
notlesh pushed a commit that referenced this pull request Sep 5, 2024
HermanObst pushed a commit that referenced this pull request Sep 10, 2024
* wip: attempt to handle kzq_da

* add: wip kzg da hints implementation

* wip: kzg unknown da_size

* lint: clippy fix

* fix: rename zkg to kzg

* update: kzg fft method and tests

* ensure non-negative numbers on diff

* fix: os output and add specific tests

* lint: clippy fixes

* fix: update the new api

* more zkg -> kzg renaming

* fix: use log instead of println

Co-authored-by: Olivier Desenfans <[email protected]>

* fix: remove unnecessary code

* Update crates/starknet-os/src/hints/kzg.rs

Co-authored-by: Olivier Desenfans <[email protected]>

* fix: missing parts of kzg, added vars

* L1 handler tx (#344)

* support for L1 Handler txs

* fixes from review

* Chore: bump Blockifier to 0.8.0-rc.3 (#345)

* Look for classes in subcalls in addition to contracts (#347)

* Implement kzg commitment hint

* Fixes

* Clean up post-merge

* Add kzg_manager.rs

* Resolve clippy nits

* s/5/6/

* Remove orphaned hint

* Clean up mangled comment

* Remove unused import

* Fix BLOB_LENGTH constant lookup

* Use from c_kzg::Error

Co-authored-by: Olivier Desenfans <[email protected]>

* Add Blob DA blocks to prove_block test

* Oops, wrong block number

* Derive number of zkg felts to ignore in os output

* doc: improve documentation on fft recursive method

* doc: for the recursive fft method

---------

Co-authored-by: ftheirs <[email protected]>
Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Stephen Shelton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants