Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Implement KZG commitment functionality and hints #304

Merged
merged 38 commits into from
Sep 10, 2024
Merged

Feature: Implement KZG commitment functionality and hints #304

merged 38 commits into from
Sep 10, 2024

Conversation

whichqua
Copy link
Collaborator

@whichqua whichqua commented Aug 8, 2024 •
edited
Loading

This pull request adds a new hint related to the KZG commitment functionality, implementing KZG commitment generation and testing it.
It includes the introduction of FFT and blob handling for KZG commitments.

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Related

#176

Requires Moonsong-Labs/cairo-vm#41

Breaking changes?

  • yes
  • no

@whichqua whichqua changed the title wip: handle kzq_da hints wip: handle kzg_da hints Aug 13, 2024
@whichqua whichqua changed the title wip: handle kzg_da hints Feature: WRITE_KZG_COMMITMENT hint Aug 16, 2024
@whichqua whichqua marked this pull request as ready for review August 16, 2024 15:14
@odesenfans odesenfans mentioned this pull request Aug 22, 2024
Closed
9 tasks
odesenfans
odesenfans suggested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some simple comments, I need to review the code this is coming from in depth.

crates/starknet-os/kzg/trusted_setup.txt Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/block_context.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
odesenfans
odesenfans suggested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments on the FFT part, I need the source for the rest of the code to continue the review.

Cargo.toml Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Show resolved Hide resolved
odesenfans
odesenfans suggested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a block with KZG to the prove block itests.

crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/kzg.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/hints/os.rs Show resolved Hide resolved
crates/starknet-os/src/io/output.rs Outdated Show resolved Hide resolved
crates/starknet-os/src/starknet/core/os/kzg_manager.rs Show resolved Hide resolved
@notlesh notlesh mentioned this pull request Sep 6, 2024
Open
HermanObst
HermanObst requested changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@HermanObst HermanObst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notlesh please add the integration test with the "blob" blocks that now are passing :)

@notlesh
Copy link
Collaborator

notlesh commented Sep 9, 2024

@notlesh please add the integration test with the "blob" blocks that now are passing :)

Done, I added two at random out of about a dozen that I found.

@whichqua
Copy link
Collaborator Author

whichqua commented Sep 9, 2024

We should also possibly retitle this PR to represent the current work.

@whichqua whichqua changed the title Feature: WRITE_KZG_COMMITMENT hint Feature: Implement KZG commitment functionality and hints Sep 10, 2024
@HermanObst HermanObst merged commit 7cde766 into main Sep 10, 2024
6 checks passed
@HermanObst HermanObst deleted the gm/kzg-da branch September 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlesh notlesh notlesh left review comments

@HermanObst HermanObst HermanObst approved these changes

@odesenfans odesenfans odesenfans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whichqua @notlesh @odesenfans @HermanObst @ftheirs