Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SECP syscall and hints support #288

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Feature: SECP syscall and hints support #288

merged 6 commits into from
Aug 29, 2024

Conversation

odesenfans
Copy link
Contributor

@odesenfans odesenfans commented Jul 31, 2024

Implement SECP syscalls and hints.

TODO:

  • SECP syscalls
  • SECP hints
  • Uncomment keccak verification in test

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

whichqua and others added 5 commits August 29, 2024 15:50
This PR handles all the Secp syscalls for both `k1` and `r1` curves. It includes:

- secp_new
- secp_add
- secp_mul
- secp_get_point_from_x
- secp_get_xy
This PR adds hints and compatibility with secp syscalls.

---------

Co-authored-by: Olivier Desenfans <[email protected]>
@odesenfans odesenfans marked this pull request as ready for review August 29, 2024 14:42
@odesenfans odesenfans requested a review from notlesh as a code owner August 29, 2024 14:42
@odesenfans odesenfans changed the title WIP: SECP syscall and hints support Feature: SECP syscall and hints support Aug 29, 2024
@odesenfans odesenfans merged commit db7810b into main Aug 29, 2024
6 checks passed
@odesenfans odesenfans deleted the dev-secp-support branch August 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants