Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement Secp Syscalls #286

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

whichqua
Copy link
Collaborator

This PR handles all the Secp syscalls for both k1 and r1 curves. It includes:

  • secp_new
  • secp_add
  • secp_mul
  • secp_get_point_from_x
  • secp_get_xy

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

whichqua added 2 commits July 29, 2024 16:58
fix: get the right types of values when checking execution failures

fix: some minor fixes

fix: get the syscalls working

refactor: use blockifier and remove lots of dead code
@whichqua whichqua mentioned this pull request Jul 30, 2024
9 tasks
@whichqua whichqua marked this pull request as ready for review July 30, 2024 15:52
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odesenfans odesenfans merged commit 8839689 into dev-secp-support Jul 31, 2024
5 checks passed
@odesenfans odesenfans deleted the od/secp-wip-rebased branch July 31, 2024 09:38
odesenfans pushed a commit that referenced this pull request Aug 6, 2024
This PR handles all the Secp syscalls for both `k1` and `r1` curves. It includes:

- secp_new
- secp_add
- secp_mul
- secp_get_point_from_x
- secp_get_xy
odesenfans pushed a commit that referenced this pull request Aug 29, 2024
This PR handles all the Secp syscalls for both `k1` and `r1` curves. It includes:

- secp_new
- secp_add
- secp_mul
- secp_get_point_from_x
- secp_get_xy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants