Unhide cookiecutter errors in kedro new
#3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
ElenaKhaustova
force-pushed
the
feature/2564-unhide-cookiecutter-errors
branch
from
22b4cc9 to
8f82253
Compare
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
noklam
reviewed
Mar 12, 2024
tests/framework/cli/test_starters.py
Outdated
| def test_cookiecutter_exception_if_no_verbose(self, fake_kedro_cli): | ||
| """Check if original cookiecutter exception present in the output if no verbose | ||
| flag provided.""" | ||
| KedroCliError.VERBOSE_EXISTS = True |
There was a problem hiding this comment.
Does that mean to reset the side-effect from the other test? If so I think we make sure this happen after that test so when we add new test in the future or reordering tests won't fail again.
There was a problem hiding this comment.
Makes sense, will move it to the end of the that test.
Signed-off-by: Elena Khaustova <[email protected]>
ElenaKhaustova
changed the title
kedro new
Signed-off-by: Elena Khaustova <[email protected]>
|
🥳 |
merelcht
approved these changes
Mar 13, 2024
| @@ -1,6 +1,7 @@ | |||
| # Upcoming Release 0.19.4 | |||
|
|
|||
| ## Major features and improvements | |||
| * Cookiecutter errors are shown in short format without the `--verbose` flag. | |||
There was a problem hiding this comment.
Are the error now shown partly for all CLI commands or just kedro new?
There was a problem hiding this comment.
Now they're shown in short format for all commands but just for cookiecutter errors. So instead of Error: Failed to generate project when running cookiecutter. we will also get one line with a real error.
noklam
approved these changes
Mar 14, 2024
|
This works beautifully, thanks @ElenaKhaustova ! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #2564
Development notes
kedro new, so when--verboseflag is not provided short cookiecutter error is in the output; with--verboseflag full cookiecutter error is in the output;--verboseflag is provided;test_run_with_invalid_configtest that was changing the behaviour of the added test by modifying the global objectKedroCliError. The reason of it is calling_validate_config_filethat setsKedroCliError.VERBOSE_EXISTS=False.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile