Disable rich markup if rich handler is not present

kedro/io/data_catalog.py

@@ -24,6 +24,7 @@
     generate_timestamp,
 )
 from kedro.io.memory_dataset import MemoryDataset
+from kedro.logging import fmt_rich, has_rich_handler
 
 Patterns = Dict[str, Dict[str, Any]]
 
@@ -506,8 +507,8 @@ def load(self, name: str, version: str | None = None) -> Any:
         dataset = self._get_dataset(name, version=load_version)
 
         self._logger.info(
-            "Loading data from [dark_orange]%s[/dark_orange] (%s)...",
-            name,
+            "Loading data from %s (%s)...",
+            fmt_rich(name, "dark_orange") if has_rich_handler(self._logger) else name,
             type(dataset).__name__,
             extra={"markup": True},
         )
@@ -548,8 +549,8 @@ def save(self, name: str, data: Any) -> None:
         dataset = self._get_dataset(name)
 
         self._logger.info(
-            "Saving data to [dark_orange]%s[/dark_orange] (%s)...",
-            name,
+            "Saving data to %s (%s)...",
+            fmt_rich(name, "dark_orange") if has_rich_handler(self._logger) else name,
             type(dataset).__name__,
             extra={"markup": True},
         )

kedro/logging.py

@@ -1,5 +1,6 @@
 import logging
 import sys
+from functools import lru_cache
 from pathlib import Path
 from typing import Any
 
@@ -54,3 +55,15 @@ def __init__(self, *args: Any, **kwargs: Any):
             # fixed on their side at some point, but until then we disable it.
             # See https://github.com/Textualize/rich/issues/2455
             rich.traceback.install(**traceback_install_kwargs)  # type: ignore[arg-type]
+
+
+# @cache is supported from 3.9 onwards
+@lru_cache(maxsize=None)
+def has_rich_handler(logger: logging.Logger) -> bool:
+    """Returns true if the logger has a RichHandler attached."""
+    return any(isinstance(handler, RichHandler) for handler in logger.handlers)
+
+
+def fmt_rich(value: str, markup: str) -> str:
+    """Format string with rich markup"""
+    return f"[{markup}]{value}[/{markup}]"

tests/framework/project/test_logging.py

@@ -6,6 +6,7 @@
 import yaml
 
 from kedro.framework.project import LOGGING, configure_logging, configure_project
+from kedro.logging import RichHandler, fmt_rich, has_rich_handler
 
 
 @pytest.fixture
@@ -146,6 +147,20 @@ def test_rich_traceback_disabled_on_databricks(
     rich_pretty_install.assert_called()
 
 
+def test_rich_format():
+    assert (
+        fmt_rich("Hello World!", "dark_orange")
+        == "[dark_orange]Hello World![/dark_orange]"
+    )
+
+
+def test_has_rich_handler():
+    test_logger = logging.getLogger("test_logger")
+    assert not has_rich_handler(test_logger)
+    test_logger.addHandler(RichHandler())
+    assert has_rich_handler(test_logger)
+
+
 def test_default_logging_info_emission(monkeypatch, capsys):
     # Expected path and logging configuration
     expected_path = Path("conf/logging.yml")