Disable rich markup if rich handler is not present #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noklam
reviewed
Mar 8, 2024
|
I would like this to go in please |
Signed-off-by: Simon Brugman <[email protected]>
|
Just leaving a comment here we didn't forget about this PR as we discussed internally. I will shortly review this PR. |
noklam
reviewed
May 28, 2024
|
Thanks, will do |
Signed-off-by: L. R. Couto <[email protected]>
Seconding this. |
This reverts commit 802ad26.
Signed-off-by: lrcouto <[email protected]>
|
Reverting the previous merge I did because it broke some tests. Probably gonna need a rebase because of the DCO issue though. |
deepyaman
reviewed
Jul 2, 2024
kedro/logging.py
Outdated
| @@ -54,3 +55,15 @@ def __init__(self, *args: Any, **kwargs: Any): | |||
| # fixed on their side at some point, but until then we disable it. | |||
| # See https://github.com/Textualize/rich/issues/2455 | |||
| rich.traceback.install(**traceback_install_kwargs) # type: ignore[arg-type] | |||
|
|
|||
|
|
|||
| # @cache is supported from 3.9 onwards | |||
There was a problem hiding this comment.
Nit: I would just leave out this comment; pyupgrade will take care of it when drop 3.8.
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: Nok <[email protected]>
noklam
approved these changes
Jul 5, 2024
lrcouto
approved these changes
Jul 5, 2024
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #3626
Only used in Data Catalog (2x)
Done in Github UI to start the discussion.
Will add unit tests, and add release notes.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile