-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the CONTRIBUTING.md guide: developer workflow #266
Merged
limdauto
merged 4 commits into
kedro-org:develop
from
neomatrix369:update-contribution-guide
Feb 28, 2020
Merged
Updated the CONTRIBUTING.md guide: developer workflow #266
limdauto
merged 4 commits into
kedro-org:develop
from
neomatrix369:update-contribution-guide
Feb 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow Related to issue kedro-org#256
neomatrix369
force-pushed
the
update-contribution-guide
branch
from
February 27, 2020 12:20
c0385e0
to
93dead3
Compare
limdauto
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! This looks great.
yetudada
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was such a thoughtful contribution @neomatrix369! Thank you so much for this!
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Feb 28, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Feb 28, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265 [skip ci]
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Feb 28, 2020
…elated to issue kedro-org#256. [skip ci]
6 tasks
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Mar 2, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265 [skip ci]
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Mar 2, 2020
…elated to issue kedro-org#256. [skip ci]
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Mar 9, 2020
…elated to issue kedro-org#256. [skip ci]
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Mar 9, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265 [skip ci]
limdauto
added a commit
that referenced
this pull request
Mar 10, 2020
… issue #256. [skip ci] (#270) Co-authored-by: Lim H <[email protected]>
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Mar 10, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265 [skip ci]
neomatrix369
added a commit
to neomatrix369/kedro
that referenced
this pull request
Mar 15, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265 [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the CONTRIBUTING.md guide to help with info on developer workflow
Related to issue #256
Development notes
Checklist
Opened this PR as a 'Draft Pull Request' if it is work-in-progressUpdated the documentation to reflect the code changesRELEASE.md
fileAdded tests to cover my changesNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.