Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CONTRIBUTING.md guide: developer workflow #266

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

neomatrix369
Copy link
Contributor

@neomatrix369 neomatrix369 commented Feb 26, 2020

Description

Updated the CONTRIBUTING.md guide to help with info on developer workflow

Related to issue #256

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@neomatrix369 neomatrix369 requested a review from idanov as a code owner February 26, 2020 22:50
@neomatrix369 neomatrix369 force-pushed the update-contribution-guide branch from c0385e0 to 93dead3 Compare February 27, 2020 12:20
@limdauto limdauto self-requested a review February 28, 2020 13:28
@limdauto limdauto self-assigned this Feb 28, 2020
Copy link
Contributor

@limdauto limdauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! This looks great.

@limdauto limdauto requested a review from yetudada February 28, 2020 13:38
Copy link
Contributor

@yetudada yetudada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was such a thoughtful contribution @neomatrix369! Thank you so much for this!

@limdauto limdauto merged commit 3ea955d into kedro-org:develop Feb 28, 2020
@neomatrix369 neomatrix369 deleted the update-contribution-guide branch February 28, 2020 16:20
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Feb 28, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Feb 28, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265

[skip ci]
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Feb 28, 2020
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Mar 2, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265

[skip ci]
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Mar 2, 2020
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Mar 9, 2020
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Mar 9, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265

[skip ci]
limdauto added a commit that referenced this pull request Mar 10, 2020
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Mar 10, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265

[skip ci]
neomatrix369 added a commit to neomatrix369/kedro that referenced this pull request Mar 15, 2020
…elated to issue kedro-org#256. Added new release notes entry for PR kedro-org#268, related to issue kedro-org#265

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants