Fix/multiple experiment tracking run menus #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
tynandebold
requested review from
Huongg,
rashidakanchwala,
comym,
cvetankanechevska and
Mackay031
…x/multiple-exp-tracking-run-menus Signed-off-by: Tynan DeBold <[email protected]>
comym
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #894.
Development notes
I've added a custom
useOutsideClick()hook that will detect when a user clicks outside of a specific element, and when they do, a function will do something. In our case, it will close the menu that was open.QA notes
Open the Gitpod preview URL and ensure that you can't have multiple experiment tracking run menus open at the same time.
Checklist
RELEASE.mdfile