Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KED - 857] Improve telemetry to work with SVG elements #865

Merged
merged 1 commit into from
May 25, 2022
Merged

[KED - 857] Improve telemetry to work with SVG elements #865

merged 1 commit into from
May 25, 2022

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented May 24, 2022 •
edited by gitpod-io bot
Loading

Description

Resolves #857

Development notes

I have added the 'node type' to rectangle as on heap the rect svg is what gets registered. I have also defined multiple events on HEAP (Dataset selected, Task node selected, Parameter node selected, Modular pipelines selected'

Screenshot 2022-05-24 at 18 34 04

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

tynandebold
tynandebold approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great.

@rashidakanchwala rashidakanchwala merged commit 8fa1cd7 into main May 25, 2022
@rashidakanchwala rashidakanchwala deleted the ked-857/fix/svg-in-telemetry branch May 25, 2022 08:41
@tynandebold tynandebold mentioned this pull request Jun 16, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynandebold tynandebold tynandebold approved these changes

@yetudada yetudada Awaiting requested review from yetudada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve telemetry to work with SVG elements
2 participants
@rashidakanchwala @tynandebold