[KED-2417] Clean up SCSS tech debt #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'icon' bit didn't make any sense
This is a more sensible place for it to live, now that it's only applied in one place
This will allow consistent font-sizing and font-family for the entire application regardless of whether a developer adds the `kedro` class to its immediate parent.
bru5
approved these changes
Feb 24, 2021
studioswong
reviewed
Feb 24, 2021
studioswong
approved these changes
Feb 24, 2021
richardwestenra
changed the title
richardwestenra
changed the title
richardwestenra
added a commit
that referenced
this pull request
Mar 2, 2021
# Release 3.10.0 ## Major features and improvements - Display a prompt before rendering very large graphs (#361, #376, #377, #381) ## Bug fixes and other changes - Clean up SCSS tech debt (#380) - Add Container component to simplify app/lib entrypoint (#379) - Add stylelint 'rule-empty-line-before': 'always' (#378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kedroclass to wrapper - This will allow consistent font-sizing and font-family for the entire application regardless of whether a developer adds thekedroclass to its immediate parent.Development notes
See https://github.com/quantumblacklabs/kedro-ui/pull/84 for a description of the backstory of the 'kedro' class (and please review that PR while you're there! :)
QA notes
No expected changes.
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.