Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2453] Update large pipeline warning copy #377

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

richardwestenra
Copy link
Contributor

@richardwestenra richardwestenra commented Feb 20, 2021

Description

  1. Let's avoid saying "your pipeline" - we don't want to shame our users for their big-ass pipelines or make them look bad in front of a client. It's not a bad thing to be little on the large side, there's just more to love 😌
  2. Let's inject a little levity and humanity into this message - studies show that even in corporate environments, when people use humour in the workplace, they are 23% more respected and are seen as more competent and more confident. Even executives have a sense of humour, they just don’t want us to imply that their work is of poor quality.
  3. Let's use 'will' instead of 'might' - as @stichbury said, "I never like the 'might' word, because it implies doubt, and certainty is a nice thing for a reader."
  4. Let's avoid needless repetition. There's no need to say "click to render", just show the button which says this anyway. Also, we prefer to avoid saying "click" because this implies that the user is navigating with a mouse, when they might be using a keyboard, touchpad or touchscreen.

image

Development notes

I've changed the max-width of the paragraph text to 30em, as this is the ideal width to split the two sentences onto two lines, and it is dependent on the font-size so the line-split will remain constant if the text size changes.

QA notes

Updated copy. The only thing worth checking is how this renders across screen widths and when the sidebar is open/closed.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Change the max-width to 30em, as this is the ideal width to split the two sentences onto two lines, and this is dependent on the font-size.
Copy link
Contributor

@studioswong studioswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @richardwestenra ! I am fine with both the previous copy and this one and will leave it up to @stichbury and @yetudada . I recall Joel mentioned about the tone of voice for the warning given we have to be mindful for client presentations, so might be worth checking in with him as well?

Copy link
Contributor

@datajoely datajoely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - let's ship it. Can we track how many times it's fired and the associated node count?

@richardwestenra
Copy link
Contributor Author

@datajoely Thanks! We don't have tracking yet, but I'd love to track node/dataset/edge counts once we do.

@richardwestenra richardwestenra merged commit 766a743 into main Feb 22, 2021
@richardwestenra richardwestenra deleted the feature/sizewarning-copy branch February 22, 2021 13:00
@datajoely
Copy link
Contributor

@datajoely Thanks! We don't have tracking yet, but I'd love to track node/dataset/edge counts once we do.

Render time would be great too

@richardwestenra richardwestenra mentioned this pull request Mar 2, 2021
1 task
richardwestenra added a commit that referenced this pull request Mar 2, 2021
# Release 3.10.0

## Major features and improvements

- Display a prompt before rendering very large graphs (#361, #376, #377, #381)

## Bug fixes and other changes

- Clean up SCSS tech debt (#380)
- Add Container component to simplify app/lib entrypoint (#379)
- Add stylelint 'rule-empty-line-before': 'always' (#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants